Skip to content

Only add GCC Clang warnings options in GCC/Clang #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 12, 2025
Merged

Only add GCC Clang warnings options in GCC/Clang #64

merged 4 commits into from
Sep 12, 2025

Conversation

@traversaro
Copy link
Contributor

@traversaro traversaro commented Sep 12, 2025

No description provided.

@hrp2-14
Copy link

hrp2-14 commented Sep 12, 2025

Hi ! This project doesn't usually accept pull requests on the main branch.
If this wasn't intentionnal, you can change the base branch of this PR to devel
(No need to close it for that). Best, a bot.

@nim65s nim65s changed the base branch from master to devel September 12, 2025 13:02
@nim65s
Copy link
Contributor

nim65s commented Sep 12, 2025

thanks for this :)
Let me have a look at the CI first, and I'll come back to this 😅

@traversaro
Copy link
Contributor Author

traversaro commented Sep 12, 2025

thanks for this :) Let me have a look at the CI first, and I'll come back to this 😅

No problem! I will iterate parallelly in conda-forge/eiquadprog-feedstock#15, I suspect this is not the only Windows-related change.

nim65s
nim65s reviewed Sep 12, 2025
View reviewed changes
Copy link
Contributor

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format nit + avoid CMAKE_COMPILER_IS_GNUCC deprecated in 3.24

nim65s
nim65s approved these changes Sep 12, 2025
View reviewed changes
Copy link
Contributor

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
@traversaro : is it OK for you if I squash merge now ?

@traversaro
Copy link
Contributor Author

traversaro commented Sep 12, 2025

conda-forge/eiquadprog-feedstock#15 seems to be working fine.

lgtm. @traversaro : is it OK for you if I squash merge now ?

Yes, thanks! I love anything that avoids me to manually curate commits. :D

@traversaro traversaro mentioned this pull request Sep 12, 2025
Merged
5 tasks
@nim65s nim65s merged commit b6dd0aa into stack-of-tasks:devel Sep 12, 2025
10 checks passed
@traversaro traversaro deleted the patch-1 branch September 12, 2025 14:15
@traversaro traversaro mentioned this pull request Nov 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nim65s nim65s nim65s approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@traversaro @hrp2-14 @nim65s